refactor(electron-titlebar): use relative units for electron-titlebar#1870
Merged
refactor(electron-titlebar): use relative units for electron-titlebar#1870
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the $si-titlebar-height variable from pixels to rem units. While the conversion is accurate, it introduces a unit inconsistency with adjacent layout variables like $si-application-header-height and $si-system-banner-height. It is recommended to convert all related layout dimensions in this block to relative units to ensure consistent scaling across the application.
spliffone
force-pushed
the
feat/electron-titlebar-relative-sizing
branch
from
bb63c41 to
5e1ac65
Compare
dr-itz
reviewed
Apr 21, 2026
spliffone
force-pushed
the
feat/electron-titlebar-relative-sizing
branch
from
689277c to
7116e74
Compare
dr-itz
approved these changes
Apr 21, 2026
Contributor
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://code.siemens.com/simpl/simpl-element/-/work_items/4
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: